fix: setup.py should generate importable packages named <project>_client (closes #520)#521
Merged
dbanty merged 1 commit intoopenapi-generators:mainfrom Oct 25, 2021
Merged
Conversation
Collaborator
Codecov Report
@@ Coverage Diff @@
## main #521 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 48 48
Lines 1639 1639
=========================================
Hits 1639 1639 Continue to review full report at Codecov.
|
This was
linked to
issues
Oct 25, 2021
Collaborator
|
Some cursory testing tells me that this does fix #492. Though, admittedly, I don't really understand |
dbanty
approved these changes
Oct 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to allow multiple clients generated to be installed via setup.py, update the generated setup.py file so that the package installed is available to clients as
from <my_api>_client import Clientrather than just
import ClientThis is accomplished by specifying
packages=["{{package_name}}"]in the setup.py.jinja2 file and removing thepackage_dir={"": "{{ package_name }}"},directive.