Skip to content

Add a setting to override the package version #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

fyhertz
Copy link

@fyhertz fyhertz commented Oct 28, 2020

A generate package version actually depends on the version of the
OpenAPI spec and on the version of the generator. Upgrading the
generator version may break backward compatibility of the client. This
gives the user the possibility to bump its client version to reflect
changes in the generated code even though the spec has not changed.

A generate package version actually depends on the version of the
OpenAPI spec and on the version of the generator. Upgrading the
generator version may break backward compatibility of the client. This
gives the user the possibility to bump its client version to reflect
changes in the generated code even though the spec has not changed.
@fyhertz fyhertz force-pushed the feature/package-version-from-config branch from 36026d1 to d5a7c71 Compare November 3, 2020 14:21
@codecov
Copy link

codecov bot commented Nov 3, 2020

Codecov Report

Merging #225 into main will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #225   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           41        41           
  Lines         1299      1302    +3     
=========================================
+ Hits          1299      1302    +3     
Impacted Files Coverage Δ
openapi_python_client/__init__.py 100.00% <100.00%> (ø)
openapi_python_client/config.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e54468f...d5a7c71. Read the comment docs.

@dbanty
Copy link
Collaborator

dbanty commented Nov 3, 2020

Thanks @fyhertz! I copied this over to another PR so I could add notes in the README and CHANGELOG about it.

@dbanty dbanty closed this Nov 3, 2020
@fyhertz fyhertz deleted the feature/package-version-from-config branch May 10, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants