Does the generator support binary request bodies?

[rtaycher]

Not a multipart form request.

The api I'm looking at submits the binary as the request body. I think this is representable in openapi and can be sent as content in httpx but the generator seems to try to send it as json (if i falsely call it json) using a File that returns payload, filename, optional content type. I think that's meant for httpx multipart api

or it ignores it if I set octet stream content in the openapi

[dbanty]

I know we support application/octet-stream as binary data in a response but I don't think it's been added as a body.

If someone wants to take a swing at implementing, you can probably use openapi_python_client.parser.openapi.Endpoint.parse_request_json_body as a jumping off point. Use a similar pattern but swap out the content type. Then it'll need to verify that the generated property is of the appropriate bytes type, which I think is a binary format on string type. That would come out as FileProperty which isn't quite the right name anymore I suppose 🤔.

The last thing would be to add support in openapi_python_client/templates/endpoint_module.py.jinja for reading the new binary_body (or whatever it's called) and putting it in the right part of the request. I think that would be the content param for httpx . I don't know if that is smart enough to set the content-type correctly though, so that may need to be set by hand as well.

Quite a few steps 😅. I'm unlikely to get time to do that all myself anytime soon—but I'm happy to provide more guidance if someone wants to pick it up.

[dbanty]

This is now supported in 0.16.0 for application/octet-stream