Skip to content

Commit d0b2afe

Browse files
committed
🔊 (manager) Log error on file not found and don't emit
1 parent 0335bee commit d0b2afe

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

ingestors/manager.py

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -193,14 +193,15 @@ def ingest_entity(self, entity):
193193
file_name = entity_filename(entity)
194194
file_path = self.load(content_hash, file_name=file_name)
195195
if file_path is None or not file_path.exists():
196-
log.warning(
196+
log.error(
197197
f"Couldn't find file named {file_name} at path {file_path}."
198198
"Skipping ingestion."
199199
)
200200
continue
201201
self.ingest(file_path, entity)
202202
return
203-
self.finalize(entity)
203+
# don't emit this entity if we didn't find a file to ingest
204+
self.finalize(entity, emit=False)
204205

205206
def ingest(self, file_path, entity, **kwargs):
206207
"""Main execution step of an ingestor."""
@@ -246,8 +247,9 @@ def ingest(self, file_path, entity, **kwargs):
246247
finally:
247248
self.finalize(entity)
248249

249-
def finalize(self, entity):
250-
self.emit_entity(entity)
250+
def finalize(self, entity, emit: bool | None = True):
251+
if emit:
252+
self.emit_entity(entity)
251253
self.writer.flush()
252254
remove_directory(self.work_path)
253255

0 commit comments

Comments
 (0)