Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recording of reponse headers in exceptions. #44

Merged
merged 1 commit into from
Jan 19, 2022

Conversation

max-schaefer
Copy link
Contributor

These were passed as positional arguments, but in the wrong position, which meant they were passed into the json_body parameter of the OpenAIError constructor.

These were passed as positional arguments, but in the wrong position, which meant they were passed into the `json_body` parameter of the `OpenAIError` constructor.
@hallacy hallacy self-requested a review January 19, 2022 22:24
Copy link
Collaborator

@hallacy hallacy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep thats wrong. Thanks for the fix!

@hallacy hallacy merged commit 7ea5dde into openai:main Jan 19, 2022
baseprime pushed a commit to breezerfp/breeze-openai that referenced this pull request Mar 20, 2024
* Revamp cli args (openai#45)

* Rachel/follow (openai#46)

* Add fine_tunes.follow. Add better error handling for disconnected streams

* return early

* fix an oops

* lint

* Nicer strings

* ensure end token is not applied to classification (openai#44)

* ensure end token is not applied to classification

* black

Co-authored-by: Boris Power <81998504+BorisPower@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants