Add deployment_id parameter for azure #109
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dd-deployment_id-parameter-for-azure
|
@t-asutedjo is this ready for review? |
Yes |
sorinsuciu-msft
approved these changes
Jul 12, 2022
|
@hallacy This seems complete, could you please have a final look and merge it? Thanks |
hallacy
approved these changes
Jul 20, 2022
|
Nice! Thanks for pulling the common error message out to the base class! |
techthiyanes
pushed a commit
to techthiyanes/openai-python
that referenced
this pull request
Oct 2, 2023
* Hallacy/pickleable exceptions (openai#109) * Exceptions in python are hard to pickle. Make Exceptions pickleable * Remove debug * Added tests * nit * Change embeddings call to openai.Embedding.create (openai#110) * Change embeddings call to openai.Embedding.create * And update model names * Untweak notebook * Support encoded embeddings response (openai#111) * Support encoded embeddings response * Removed imports * Add a couple of comments * Typo * Remove CA bundle (openai#112) * Remove CA bundle * Removed some references
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for a deployment_id parameter for azure. The "deployment_id" parameter overloads the engine parameter. (Similar to as "model" overloads the "engine" parameter for openai)
Parameter checks and exceptions are refactored and moved into the EngineApiResource base class.