Skip to content

Commit 4f1b691

Browse files
authored
fix(uploads): avoid file handle leak
1 parent d0370a8 commit 4f1b691

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

src/openai/resources/uploads/uploads.py

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -157,9 +157,8 @@ def upload_file_chunked(
157157
part = self.parts.create(upload_id=upload.id, data=data)
158158
log.info("Uploaded part %s for upload %s", part.id, upload.id)
159159
part_ids.append(part.id)
160-
except Exception:
160+
finally:
161161
buf.close()
162-
raise
163162

164163
return self.complete(upload_id=upload.id, part_ids=part_ids, md5=md5)
165164

@@ -465,9 +464,8 @@ async def upload_file_chunked(
465464
part = await self.parts.create(upload_id=upload.id, data=data)
466465
log.info("Uploaded part %s for upload %s", part.id, upload.id)
467466
part_ids.append(part.id)
468-
except Exception:
467+
finally:
469468
buf.close()
470-
raise
471469

472470
return await self.complete(upload_id=upload.id, part_ids=part_ids, md5=md5)
473471

0 commit comments

Comments
 (0)