fix: issue 1684 to remove "/deployments/${model}" in the path if it uses azure openai v1 api #1692
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use azure openai v1 api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
Currently it will throw 404 error when you call azure openai v1 chat completion api (See detail at #1684)
This is due to azure openai v1 api changed its url which removed
/deployments/${model}in the path.This problem should occurs not only in
chatcompletionapi but also inembeddingapi (for all methods which exist both in v1 and in_deployments_endpointsarray)So I added a condition check here
Additional context & links
I tested it with
chatcompletionapi ,it works fine after change.But my project doesn't use
embeddingapi, I don't test it