fix(embeddings): correctly decode base64 data #1448
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to NodeJS docs Buffer.buffer is not guaranteed to correspond exactly to the original Buffer. [1] The previous implementation could use buffer garbage while converting bytes to floats. [1] https://nodejs.org/api/buffer.html#bufbuffer
1 task
RobertCraigie
changed the title
RobertCraigie
force-pushed
the
fix-to-float32-array
branch
2 times, most recently
from
ff16ce4 to
d6152f2
Compare
|
Thanks for the PR! I've pushed a couple commits to fix some formatting and expand our test suite to catch this issue. I also verified that the first embedding matches the python SDK behaviour. |
RobertCraigie
approved these changes
Apr 7, 2025
RobertCraigie
changed the title
Merged
stainless-app bot
pushed a commit
that referenced
this pull request
Apr 7, 2025
* Fix Core.toFloat32Array, Buffer version According to NodeJS docs Buffer.buffer is not guaranteed to correspond exactly to the original Buffer. [1] The previous implementation could use buffer garbage while converting bytes to floats. [1] https://nodejs.org/api/buffer.html#bufbuffer * add tests for embeddings data * fix formatting --------- Co-authored-by: Robert Craigie <robert@craigie.dev>
Merged
23 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes being requested
According to NodeJS docs Buffer.buffer is not guaranteed to correspond exactly to the original Buffer.
The previous implementation could use buffer garbage while converting bytes to floats.
Additional context & links
https://nodejs.org/api/buffer.html#bufbuffer
Fixes #1446