Only include stream_options when streaming #519
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym-oai
reviewed
Apr 15, 2025
| @@ -591,8 +593,11 @@ def get_store_param(cls, client: AsyncOpenAI, model_settings: ModelSettings) -> | |||
|
|
|||
| @classmethod | |||
| def get_stream_options_param( | |||
| cls, client: AsyncOpenAI, model_settings: ModelSettings | |||
| cls, client: AsyncOpenAI, model_settings: ModelSettings, stream: bool | |||
There was a problem hiding this comment.
uber nit: isn't it easier to do _Converter.get_stream_options_param() if stream else None in the method above?
There was a problem hiding this comment.
IMO no because this way the logic for stream_options is all in one place
pakrym-oai
approved these changes
Apr 15, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #518