Skip to content

Previous response id #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 15, 2025
Merged

Previous response id #509

merged 2 commits into from
Apr 15, 2025

Conversation

rm-openai
Copy link
Collaborator

@rm-openai rm-openai commented Apr 14, 2025 •
edited
Loading

Allows passing in the previous_response_id to reduce sending the same data again and again.

Test plan:
Examples. Adding tests in next PR shortly.

@rm-openai rm-openai mentioned this pull request Apr 14, 2025
Merged
@rm-openai rm-openai requested a review from pakrym-oai April 14, 2025 22:10
pakrym-oai
pakrym-oai previously approved these changes Apr 14, 2025
View reviewed changes
rm-openai added a commit that referenced this pull request Apr 15, 2025
@rm-openai
Replace referencable_id with response_id (#508)
d6f5190 
Minor change - naming. So that it doesn't pollute the next PR.

---
[//]: # (BEGIN SAPLING FOOTER)
* #509
* __->__ #508
Base automatically changed from rm/pr508 to main April 15, 2025 01:37
@rm-openai rm-openai dismissed pakrym-oai’s stale review April 15, 2025 01:37

The base branch was changed.

@rm-openai rm-openai mentioned this pull request Apr 15, 2025
Merged
@rm-openai rm-openai merged commit 92d6e3e into main Apr 15, 2025
@rm-openai rm-openai deleted the rm/pr509 branch April 15, 2025 02:02
@rm-openai rm-openai mentioned this pull request Apr 15, 2025
Closed
@rm-openai rm-openai linked an issue Apr 15, 2025 that may be closed by this pull request
Why full history as input is still necessary? #102
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pakrym-oai pakrym-oai pakrym-oai left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Why full history as input is still necessary?
2 participants
@rm-openai @pakrym-oai