Fix mypy errors

Author: seratch

src/agents/util/_safe_copy.py

@@ -5,11 +5,13 @@
 from decimal import Decimal
 from fractions import Fraction
 from pathlib import PurePath
-from typing import Any
+from typing import Any, TypeVar
 from uuid import UUID
 
+T = TypeVar("T")
 
-def safe_copy(obj: Any) -> Any:
+
+def safe_copy(obj: T) -> T:
     """
     Copy 'obj' without triggering deepcopy on complex/fragile objects.
 
@@ -56,46 +58,46 @@ def _is_simple_atom(o: Any) -> bool:
     return isinstance(o, _SIMPLE_ATOMS)
 
 
-def _safe_copy_internal(obj: Any, memo: dict[int, Any]) -> Any:
+def _safe_copy_internal(obj: T, memo: dict[int, Any]) -> T:
     oid = id(obj)
     if oid in memo:
-        return memo[oid]
+        return memo[oid]  # type: ignore [no-any-return]
 
     # 1) Simple "atoms": safe to deepcopy (cheap, predictable).
     if _is_simple_atom(obj):
         return copy.deepcopy(obj)
 
     # 2) Containers: rebuild and recurse.
     if isinstance(obj, dict):
-        new_dict = {}
+        new_dict: dict[Any, Any] = {}
         memo[oid] = new_dict
         for k, v in obj.items():
             # preserve key identity/value, only copy the value
             new_dict[k] = _safe_copy_internal(v, memo)
-        return new_dict
+        return new_dict  # type: ignore [return-value]
 
     if isinstance(obj, list):
         new_list: list[Any] = []
         memo[oid] = new_list
         new_list.extend(_safe_copy_internal(x, memo) for x in obj)
-        return new_list
+        return new_list  # type: ignore [return-value]
 
     if isinstance(obj, tuple):
         new_tuple = tuple(_safe_copy_internal(x, memo) for x in obj)
         memo[oid] = new_tuple
-        return new_tuple
+        return new_tuple  # type: ignore [return-value]
 
     if isinstance(obj, set):
         new_set: set[Any] = set()
         memo[oid] = new_set
         for x in obj:
             new_set.add(_safe_copy_internal(x, memo))
-        return new_set
+        return new_set  # type: ignore [return-value]
 
     if isinstance(obj, frozenset):
         new_fset = frozenset(_safe_copy_internal(x, memo) for x in obj)
         memo[oid] = new_fset
-        return new_fset
+        return new_fset  # type: ignore
 
     # 3) Unknown/complex leaf: return as-is (identity preserved).
     memo[oid] = obj

tests/test_items_helpers.py

@@ -22,6 +22,7 @@
 from openai.types.responses.response_output_message_param import ResponseOutputMessageParam
 from openai.types.responses.response_output_refusal import ResponseOutputRefusal
 from openai.types.responses.response_output_text import ResponseOutputText
+from openai.types.responses.response_output_text_param import ResponseOutputTextParam
 from openai.types.responses.response_reasoning_item import ResponseReasoningItem, Summary
 from openai.types.responses.response_reasoning_item_param import ResponseReasoningItemParam
 from pydantic import TypeAdapter
@@ -116,7 +117,13 @@ def test_input_to_new_input_list_copies_the_ones_produced_by_pydantic() -> None:
     # Given a list of message dictionaries, ensure the returned list is a deep copy.
     original = ResponseOutputMessageParam(
         id="a75654dc-7492-4d1c-bce0-89e8312fbdd7",
-        content=[{"type": "text", "text": "Hey, what's up?"}],
+        content=[
+            ResponseOutputTextParam(
+                type="output_text",
+                text="Hey, what's up?",
+                annotations=[],
+            )
+        ],
         role="assistant",
         status="completed",
         type="message",
@@ -125,15 +132,15 @@ def test_input_to_new_input_list_copies_the_ones_produced_by_pydantic() -> None:
     output_item = TypeAdapter(ResponseOutputMessageParam).validate_json(original_json)
     new_list = ItemHelpers.input_to_new_input_list([output_item])
     assert len(new_list) == 1
-    assert new_list[0]["id"] == original["id"]
+    assert new_list[0]["id"] == original["id"]  # type: ignore
     size = 0
     for i, item in enumerate(original["content"]):
         size += 1  # pydantic_core._pydantic_core.ValidatorIterator does not support len()
-        assert item["type"] == original["content"][i]["type"]
-        assert item["text"] == original["content"][i]["text"]
+        assert item["type"] == original["content"][i]["type"]  # type: ignore
+        assert item["text"] == original["content"][i]["text"]  # type: ignore
     assert size == 1
-    assert new_list[0]["role"] == original["role"]
-    assert new_list[0]["status"] == original["status"]
+    assert new_list[0]["role"] == original["role"]  # type: ignore
+    assert new_list[0]["status"] == original["status"]  # type: ignore
     assert new_list[0]["type"] == original["type"]
 
 

tests/utils/test_safe_copy.py

@@ -3,6 +3,7 @@
 import io
 from decimal import Decimal
 from fractions import Fraction
+from typing import Any
 from uuid import UUID
 
 import pytest
@@ -73,7 +74,7 @@ def test_deep_copy_for_nested_containers_of_primitives():
     cpy = safe_copy(orig)
 
     # mutate original deeply
-    orig["a"][2]["z"] = (99, 100)
+    orig["a"][2]["z"] = (99, 100)  # type: ignore
 
     assert cpy == {"a": [1, 2, {"z": (3, 4)}]}  # unaffected
 
@@ -96,7 +97,7 @@ def __init__(self):
 
     # mutating the leaf reflects in the copied structure
     leaf.val = 42
-    assert cpy["k"].val == 42
+    assert cpy["k"].val == 42  # type: ignore [attr-defined]
 
 
 def test_generator_is_preserved_and_not_consumed():
@@ -146,7 +147,7 @@ class Marker:
 
 def test_cycles_are_handled_without_recursion_error():
     # a -> (a,)
-    a = []
+    a: list[Any] = []
     t = (a,)
     a.append(t)