Switch from pyzstd to zstandard #1514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josnyder-2
requested review from
andrew-openai,
etr2460 and
katyhshi
as code owners
etr2460
approved these changes
Apr 2, 2024
There was a problem hiding this comment.
lgtm! i didn't see any usage of zstd_open in the repo, so the only people this may impact is those writing their own evals and running them. I'll add this to patch notes when we do the next release (and possibly version bump since this might be a breaking change (returning a different type in this function))
Merged
etr2460
added a commit
that referenced
this pull request
Apr 17, 2024
Release 3.0.0 of evals. This is a major version bump because #1514 was a breaking change to how we handle zstd files
varad-newtuple
pushed a commit
to varad-newtuple/openai_eval
that referenced
this pull request
Oct 4, 2024
Release 3.0.0 of evals. This is a major version bump because openai/evals#1514 was a breaking change to how we handle zstd files
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The zstandard library has clearer maintainership. I have also taken this opportunity to sort the list of requirements.