-
Notifications
You must be signed in to change notification settings - Fork 7.2k
Fix spinner/Esc interrupt when MCP startup completes mid-turn #8661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
Fixes openai#7017 Signed-off-by: 2mawi2 <2mawi2@users.noreply.github.com>
f75b188 to
07991af
Compare
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
|
@2mawi2, thanks for the contribution. Sorry for the slow reply — we got behind over the holidays, but we're now back and going through the queue. Could you please fix the merge conflicts? |
Resolved conflicts in: - codex-rs/tui/src/chatwidget.rs - codex-rs/tui/src/chatwidget/tests.rs Kept unified_exec_processes rename from main and agent_turn_running field from this branch.
|
@etraut-openai done and tested one more time! |
Fixes #7017
What
Why
How