Skip to content

Conversation

@2mawi2
Copy link

@2mawi2 2mawi2 commented Jan 1, 2026

Fixes #7017

What

  • Prevent MCP startup completion from clearing the "task running" UI state during an active agent turn (spinner/status indicator stays visible; Esc interrupt keeps working).

Why

  • McpStartupComplete could call bottom_pane.set_task_running(false) while an agent turn was still running, hiding the status indicator and disabling Esc interrupt.

How

  • Track agent_turn_running separately and set effective running state as agent_turn_running || mcp_startup_status.is_some() (applied to both codex-rs/tui and codex-rs/tui2).
  • Add regression tests ensuring McpStartupComplete does not clear task_running/status indicator after TaskStarted.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 1, 2026

All contributors have signed the CLA ✍️ ✅
Posted by the CLA Assistant Lite bot.

@2mawi2
Copy link
Author

2mawi2 commented Jan 1, 2026

I have read the CLA Document and I hereby sign the CLA

github-actions bot added a commit that referenced this pull request Jan 1, 2026
Fixes openai#7017

Signed-off-by: 2mawi2 <2mawi2@users.noreply.github.com>
@etraut-openai
Copy link
Collaborator

@codex review

@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Didn't find any major issues. Nice work!

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@etraut-openai
Copy link
Collaborator

@2mawi2, thanks for the contribution. Sorry for the slow reply — we got behind over the holidays, but we're now back and going through the queue.

Could you please fix the merge conflicts?

@etraut-openai etraut-openai added the needs-response Additional information is requested label Jan 7, 2026
Resolved conflicts in:
- codex-rs/tui/src/chatwidget.rs
- codex-rs/tui/src/chatwidget/tests.rs

Kept unified_exec_processes rename from main and agent_turn_running field from this branch.
@2mawi2
Copy link
Author

2mawi2 commented Jan 8, 2026

@etraut-openai done and tested one more time!

@etraut-openai etraut-openai removed the needs-response Additional information is requested label Jan 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Loading spinner not showing when starting codex with initial prompt

2 participants