Skip to content

Commit 5eb4a3a

Browse files
committed
macOS: raise deployment target to 10.13
``` error: 'visit<(lambda at ...include/openPMD/backend/Attribute.hpp:239:9), std::variant<...> &>' is unavailable: introduced in macOS 10.13 ``` `std::filesystem` needs macOS 10.15: ``` share/openPMD/thirdParty/toml11/toml/parser.hpp:2166:65: error: 'path' is unavailable: introduced in macOS 10.15 basic_value<Comment, Table, Array> parse(const std::filesystem::path& fpath) ^ /Applications/Xcode_13.1.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX12.0.sdk/usr/include/c++/v1/filesystem:902:24: note: 'path' has been explicitly marked unavailable here class _LIBCPP_TYPE_VIS path { ^ ```
1 parent 8352d21 commit 5eb4a3a

File tree

1 file changed

+2
-1
lines changed

1 file changed

+2
-1
lines changed

.github/workflows/macos.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -27,10 +27,11 @@ jobs:
2727
brew install python || true
2828
set -e
2929
- name: Build
30-
env: {CXXFLAGS: -Werror -Wno-deprecated-declarations, MACOSX_DEPLOYMENT_TARGET: 10.9}
30+
env: {CXXFLAGS: -Werror -Wno-deprecated-declarations -DTOML11_DISABLE_STD_FILESYSTEM, MACOSX_DEPLOYMENT_TARGET: 10.13}
3131
# C++11 & 14 support in macOS 10.9+
3232
# C++17 support in macOS 10.13+/10.14+
3333
# https://cibuildwheel.readthedocs.io/en/stable/cpp_standards/#macos-and-deployment-target-versions
34+
# std::filesystem needs macOS 10.15
3435
run: |
3536
share/openPMD/download_samples.sh build
3637
chmod u-w build/samples/git-sample/*.h5

0 commit comments

Comments
 (0)