feat : Document Migrated to CMP #2402
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # cmp-navigation/build.gradle.kts # cmp-navigation/src/commonMain/kotlin/cmp/navigation/di/KoinModules.kt # cmp-navigation/src/commonMain/kotlin/cmp/navigation/navigation/FeatureNavHost.kt # settings.gradle.kts
itsPronay
suggested changes
Jun 13, 2025
cmp-navigation/src/commonMain/kotlin/cmp/navigation/navigation/FeatureNavHost.kt
Outdated
Show resolved
Hide resolved
core/network/src/commonMain/kotlin/com/mifos/core/network/services/DocumentService.kt
Outdated
Show resolved
Hide resolved
core/network/src/commonMain/kotlin/com/mifos/core/network/services/DocumentService.kt
Outdated
Show resolved
Hide resolved
...t/src/commonMain/kotlin/com/mifos/feature/document/documentDialog/DocumentDialogViewModel.kt
Outdated
Show resolved
Hide resolved
...t/src/commonMain/kotlin/com/mifos/feature/document/documentDialog/DocumentDialogViewModel.kt
Outdated
Show resolved
Hide resolved
...t/src/commonMain/kotlin/com/mifos/feature/document/documentDialog/DocumentDialogViewModel.kt
Outdated
Show resolved
Hide resolved
...document/src/commonMain/kotlin/com/mifos/feature/document/documentList/DocumentListScreen.kt
Outdated
Show resolved
Hide resolved
...e/document/src/commonMain/kotlin/com/mifos/feature/document/navigation/DocumentNavigation.kt
Outdated
Show resolved
Hide resolved
...e/document/src/commonMain/kotlin/com/mifos/feature/document/navigation/DocumentNavigation.kt
Outdated
Show resolved
Hide resolved
...ument/src/commonMain/kotlin/com/mifos/feature/document/documentList/DocumentListViewModel.kt
Outdated
Show resolved
Hide resolved
biplab1
reviewed
Jun 13, 2025
feature/document/src/commonMain/composeResources/values/strings.xml
Outdated
Show resolved
Hide resolved
|
@revanthkumarJ later i will review it and let you know |
...t/src/commonMain/kotlin/com/mifos/feature/document/documentDialog/DocumentDialogViewModel.kt
Outdated
Show resolved
Hide resolved
...t/src/commonMain/kotlin/com/mifos/feature/document/documentDialog/DocumentDialogViewModel.kt
Show resolved
Hide resolved
HekmatullahAmin
approved these changes
Jun 14, 2025
biplab1
reviewed
Jun 15, 2025
...t/src/commonMain/kotlin/com/mifos/feature/document/documentDialog/DocumentDialogViewModel.kt
Outdated
Show resolved
Hide resolved
|
@revanthkumarJ Could you please upload a final screen recording after applying the changes? It would help in verifying the functionality. |
biplab1
reviewed
Jun 15, 2025
...ment/src/commonMain/kotlin/com/mifos/feature/document/documentDialog/DocumentDialogScreen.kt
Outdated
Show resolved
Hide resolved
|
@biplab1 this is the latest video after doing all changes. don't consider ui/ux as we are going to use new mockups WhatsApp.Video.2025-06-15.at.12.02.15.PM.mp4 |
biplab1
approved these changes
Jun 15, 2025
|
@therajanmaurya @niyajali we can merge this one , 2 people approved |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes - Jira-#420
WhatsApp.Video.2025-06-13.at.2.54.52.PM.mp4