Bencher update #507
Merged
Bencher update #507
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add wasm_builder for building benches into wasm * colorized output
xlc
reviewed
May 31, 2021
Member
xlc
left a comment
xlc
left a comment
There was a problem hiding this comment.
Is it possible to pull build_wasm from Substrate instead of copy & paste here?
Member
Author
@xlc I had to modify the code to make some methods public. Best way will be to make a PR to build_wasm |
xlc
approved these changes
Jun 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor bencher to build and run benches without the need of a build script. Bencher will take care of ignoring methods that are already been benchmarked.