Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Haxe language related extensions #133

Closed
wants to merge 1 commit into from

Conversation

itzikiap
Copy link
Contributor

I apologize for the commits mess. Please merge these extensions definitions to the extensions json. Thanks

@spoenemann
Copy link
Collaborator

Thanks for the contribution! Unfortunately Haxe-Manager, vscode-kha and vscode-kha-extension-pack have no license. I created the following issues regarding this:

Jarrio/Haxe-Manager#17
Kode/vscode-kha#25
Kode/vscode-kha-extension-pack#2

but we have to wait until they are addressed before we can add those extensions to Open VSX.

openfl.lime-vscode-extension is duplicated, please remove one of those entries.

@mundusnine
Copy link

@itzikiap the last extension that is holding back this being merged has not been updated in years. Maybe we should remove it from this pull request for now and add it later or make it a separate pull request.

@jankeromnes
Copy link
Collaborator

@mundusnine Good idea, I agree.

@itzikiap Thanks again for your contribution! I took the liberty of:

  1. rebasing your Pull Request
  2. splitting Jarrio/Haxe-Manager out of your other changes
  3. merging your other changes as 4fb9ea3

Now the only change that remains unmerged in this Pull Request is the Jarrio/Haxe-Manager extension without a license.

@jankeromnes
Copy link
Collaborator

Update: Auto-publishing influrium.haxe-jsx worked! 🎉 https://open-vsx.org/extension/influrium/haxe-jsx

But unfortunately, auto-publishing nadako.vshaxe failed with:

...
Version f3b99c4 configured in /tmp/repository/syntaxes/.haxerc does not exist. Attempting download ...
Looking up Haxe version "f3b99c4" online
  Resolved to nightly build f3b99c4. Downloading ...
Downloading Haxe: nightly build f3b99c4
-> Done!
  ... download complete!
/tmp/repository/syntaxes/haxe_libraries/yaml.hxml:1: classpath /home/runner/haxe/haxe_libraries/hx-yaml/0.0.0/github/a90c5a93ec8ca07bd73889c1707945e02903de8e/src is not a directory or cannot be read from
'npx haxe -lib yaml -lib plist -lib hxnodejs -cp src -debug -js bin/convert.js -main Converter' exited with 244
Failed to invoke `haxelib run-dir vshaxe-build /home/runner/haxe/haxe_libraries/vshaxe-build/0.0.1/github/de0c13838c4a8bad282ef8924aa71e34a315a245 -t vshaxe -t language-server-tests -t tm-language` because Error: Command failed: haxelib run-dir vshaxe-build /home/runner/haxe/haxe_libraries/vshaxe-build/0.0.1/github/de0c13838c4a8bad282ef8924aa71e34a315a245 -t vshaxe -t language-server-tests -t tm-language
npm ERR! code ELIFECYCLE
npm ERR! errno 244
npm ERR! vshaxe@2.22.0 vscode:prepublish: `npx lix run vshaxe-build -t vshaxe -t language-server-tests -t tm-language`
npm ERR! Exit status 244
npm ERR! 
npm ERR! Failed at the vshaxe@2.22.0 vscode:prepublish script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

npm ERR! A complete log of this run can be found in:
npm ERR!     /home/runner/.npm/_logs/2020-09-30T03_39_59_370Z-debug.log
[FAIL] Could not process extension: {
  "id": "nadako.vshaxe",
  "repository": "https://github.com/vshaxe/vshaxe.git"
}
npm failed with exit code 244

@spoenemann Do you know what this could mean / how this could be resolved?

Also, the other nadako.vshaxe-dependent extensions (i.e. vshaxe.haxe-checkstyle, vshaxe.haxe-extension-pack, openfl.lime-vscode-extension, kodetech.kha and kodetech.kha-extension-pack) could not be auto-published either. They all failed with:

Error: Cannot resolve dependency: nadako.vshaxe

@AlexHaxe
Copy link

I have just updated vshaxe's package.json to include a npm install call for it's syntaxes submodule (see vshaxe/vshaxe@830fa4b). that should resolve your issue.

@jankeromnes
Copy link
Collaborator

@AlexHaxe Awesome, many thanks for the quick fix! 🙏

Also, FYI, in the long run it might make more sense if you (or other VSHaxe maintainers) publish VSHaxe to OpenVSX directly.

This repository is more of a temporary workaround to get popular open-source extensions published quickly, but it occasionally happens that (despite our best effort) we accidentally mess up packaging one or the other extension, leading to a broken upload to OpenVSX.

We're of course happy to continue doing our best to publish VSHaxe from here, but if you'd like to take over the publishing yourself, it could be just a matter of:

  • adding the single command npx ovsx publish to an existing publishing script (e.g. the one for MS Marketplace -- ovsx is also based on vsce, and npx allows you to not install any dependency)
  • setting up a OVSX_PAT env secret (you can get the value from here)

If that sounds interesting to you, I'd be more than happy to help set it up. 🙂

@jankeromnes
Copy link
Collaborator

jankeromnes commented Oct 1, 2020

Update: Ah, it seems that your fix was merged right in time before last night's publish run, so VSHaxe was already published successfully to OpenVSX: https://open-vsx.org/extension/nadako/vshaxe 🎉

That should fix the publishing of the other dependent extensions in the next publish run tonight. I'll report back if anything else is broken.

Thanks again!

@jankeromnes
Copy link
Collaborator

Good news everyone! All these extensions now also got auto-published successfully:

The extension kodetech.kha-extension-pack failed, but the error looks more like an internal problem with this repository, and once resolved I believe publishing this should work too.

The only one that still fails is:

[FAIL] Could not process extension: {
  "id": "vshaxe.haxe-extension-pack",
  "repository": "https://github.com/vshaxe/vshaxe-extension-pack.git"
}
Error: Cannot resolve bundled extension: vshaxe.haxe-debug

That one shouldn't be too hard to fix either. I think it's just a matter of auto-publishing https://github.com/vshaxe/flash-debugger first.

@jankeromnes
Copy link
Collaborator

The extension kodetech.kha-extension-pack failed, but the error looks more like an internal problem with this repository, and once resolved I believe publishing this should work too.

Actually it still fails with:

[FAIL] Could not process extension: {
  "id": "kodetech.kha-extension-pack",
  "repository": "https://github.com/Kode/vscode-kha-extension-pack"
}
Error: Cannot resolve dependency: kodetech.electron-debug

Should be resolved by 1ea9bec (we'll know tomorrow).

The only one that still fails is:
[...] vshaxe.haxe-extension-pack [...]

Still fails, but with a different error now:

[FAIL] Could not process extension: {
  "id": "vshaxe.haxe-extension-pack",
  "repository": "https://github.com/vshaxe/vshaxe-extension-pack.git"
}
Error: Cannot resolve bundled extension: vshaxe.hxcpp-debugger

This should also get resolved, by e4b7c6a

And finally, there is unfortunately still no news on Jarrio.Haxe-Manager's license: Jarrio/Haxe-Manager#17

@jankeromnes
Copy link
Collaborator

jankeromnes commented Nov 11, 2020

kodetech.kha-extension-pack also depends on https://github.com/Kode/vscode-krafix, which doesn't have a license. Will request a license there.

Error: Cannot resolve dependency: kodetech.electron-debug

Now published: https://open-vsx.org/extension/kodetech/electron-debug

Error: Cannot resolve bundled extension: vshaxe.hxcpp-debugger

Publishing failed due to missing dependency haxe:

Running: git clone --recurse-submodules https://github.com/vshaxe/hxcpp-debugger /tmp/repository
Running: git checkout 1.2.4
Running: npm install
Executing prepublish script 'npm run vscode:prepublish'...

> hxcpp-debugger@1.2.4 vscode:prepublish /tmp/repository
> haxe build.hxml

/bin/bash: haxe: command not found
npm ERR! code ELIFECYCLE
npm ERR! syscall spawn
npm ERR! file /bin/bash
npm ERR! errno ENOENT
npm ERR! hxcpp-debugger@1.2.4 vscode:prepublish: `haxe build.hxml`
npm ERR! spawn ENOENT
npm ERR! 
npm ERR! Failed at the hxcpp-debugger@1.2.4 vscode:prepublish script.

EDIT: Attempted to install it here 68e7f63

@jankeromnes
Copy link
Collaborator

Error: Cannot resolve bundled extension: vshaxe.hxcpp-debugger

Publishing failed due to missing dependency haxe:

[...]

EDIT: Attempted to install it here 68e7f63

Now failed with:

Running: git clone --recurse-submodules https://github.com/vshaxe/hxcpp-debugger /tmp/repository
Running: git checkout 1.2.4
Running: npm install
Running: npm install haxe
Executing prepublish script 'npm run vscode:prepublish'...

> hxcpp-debugger@1.2.4 vscode:prepublish /tmp/repository
> haxe build.hxml

Error: Error: Library vscode-debugadapter is not installed : run 'haxelib install vscode-debugadapter'
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! hxcpp-debugger@1.2.4 vscode:prepublish: `haxe build.hxml`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the hxcpp-debugger@1.2.4 vscode:prepublish script.

Added the suggested command in d82a8b2

@jankeromnes
Copy link
Collaborator

Now failed with:

Running: git clone --recurse-submodules https://github.com/vshaxe/hxcpp-debugger /tmp/repository
Running: git checkout 1.2.4
Running: npm install
Running: npm install haxe  && npx haxelib install vscode-debugadapter
Executing prepublish script 'npm run vscode:prepublish'...

> hxcpp-debugger@1.2.4 vscode:prepublish /tmp/repository
> haxe build.hxml

Error: Error: Library vscode is not installed : run 'haxelib install vscode'

The adventure continues!

jankeromnes added a commit that referenced this pull request Nov 23, 2020
@jankeromnes
Copy link
Collaborator

And now it failed with:

Running: git clone --recurse-submodules https://github.com/vshaxe/hxcpp-debugger /tmp/repository
Running: git checkout 1.2.4
Running: npm install
Running: npm install haxe && npx haxelib install vscode-debugadapter && npx haxelib install vscode
Executing prepublish script 'npm run vscode:prepublish'...

> hxcpp-debugger@1.2.4 vscode:prepublish /tmp/repository
> haxe build.hxml

src/Adapter.hx:4: characters 7-27 : Type not found : protocol.debug.Types
npm ERR! code ELIFECYCLE
npm ERR! errno 1

This is become a bit tedious. Maybe there are some official instructions somewhere how this should be packaged properly.

@jankeromnes
Copy link
Collaborator

@itzikiap Would you happen to know how to fix the Type not found : protocol.debug.Types error seen above that prevents vshaxe.hxcpp-debugger from being packaged?

@jankeromnes
Copy link
Collaborator

I've asked for help here: vshaxe/hxcpp-debugger#26

tennox pushed a commit to tennox/publish-extensions that referenced this pull request Jan 21, 2022
tennox pushed a commit to tennox/publish-extensions that referenced this pull request Jan 21, 2022
@filiptronicek
Copy link
Collaborator

@itzikiap do you think it's worth leaving this PR open? Currently, it is only contributing one extension with a missing license :/.

@filiptronicek filiptronicek added the changes-requested Waiting for an update label Jun 15, 2022
@itzikiap
Copy link
Contributor Author

I've closed the PR

@itzikiap itzikiap closed this Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changes-requested Waiting for an update
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants