-
Notifications
You must be signed in to change notification settings - Fork 207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Haxe language related extensions #133
Conversation
Thanks for the contribution! Unfortunately Jarrio/Haxe-Manager#17 but we have to wait until they are addressed before we can add those extensions to Open VSX.
|
@itzikiap the last extension that is holding back this being merged has not been updated in years. Maybe we should remove it from this pull request for now and add it later or make it a separate pull request. |
@mundusnine Good idea, I agree. @itzikiap Thanks again for your contribution! I took the liberty of:
Now the only change that remains unmerged in this Pull Request is the |
Update: Auto-publishing But unfortunately, auto-publishing
@spoenemann Do you know what this could mean / how this could be resolved? Also, the other
|
I have just updated vshaxe's |
@AlexHaxe Awesome, many thanks for the quick fix! 🙏 Also, FYI, in the long run it might make more sense if you (or other VSHaxe maintainers) publish VSHaxe to OpenVSX directly. This repository is more of a temporary workaround to get popular open-source extensions published quickly, but it occasionally happens that (despite our best effort) we accidentally mess up packaging one or the other extension, leading to a broken upload to OpenVSX. We're of course happy to continue doing our best to publish VSHaxe from here, but if you'd like to take over the publishing yourself, it could be just a matter of:
If that sounds interesting to you, I'd be more than happy to help set it up. 🙂 |
Update: Ah, it seems that your fix was merged right in time before last night's publish run, so VSHaxe was already published successfully to OpenVSX: https://open-vsx.org/extension/nadako/vshaxe 🎉 That should fix the publishing of the other dependent extensions in the next publish run tonight. I'll report back if anything else is broken. Thanks again! |
Good news everyone! All these extensions now also got auto-published successfully:
The extension The only one that still fails is:
That one shouldn't be too hard to fix either. I think it's just a matter of auto-publishing https://github.com/vshaxe/flash-debugger first. |
Actually it still fails with:
Should be resolved by 1ea9bec (we'll know tomorrow).
Still fails, but with a different error now:
This should also get resolved, by e4b7c6a And finally, there is unfortunately still no news on |
Now published: https://open-vsx.org/extension/kodetech/electron-debug
Publishing failed due to missing dependency
EDIT: Attempted to install it here 68e7f63 |
Now failed with:
Added the suggested command in d82a8b2 |
Now failed with:
The adventure continues! |
…om prepublish steps Attempted fix for #133 (comment)
And now it failed with:
This is become a bit tedious. Maybe there are some official instructions somewhere how this should be packaged properly. |
@itzikiap Would you happen to know how to fix the |
I've asked for help here: vshaxe/hxcpp-debugger#26 |
17cadfc
to
e4b012b
Compare
…om prepublish steps Attempted fix for open-vsx#133 (comment)
@itzikiap do you think it's worth leaving this PR open? Currently, it is only contributing one extension with a missing license :/. |
I've closed the PR |
I apologize for the commits mess. Please merge these extensions definitions to the extensions json. Thanks