Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

semconv_grouped_metrics group by root namespace uses group.id instead of metric_name to determine root namespace #289

Open
lmolkova opened this issue Aug 2, 2024 · 1 comment

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Aug 2, 2024

Try excluding v8js namespace

params:
  excluded_namespaces: [v8js]

templates:
  - pattern: semantic_metrics.j2
    filter: >
      semconv_grouped_metrics({
        "exclude_root_namespace": $excluded_namespaces
      })

As a result, v8js metrics will be generated in the file veightjs - since that's what is used in the group name.

Workaround

use excluded_namespaces: [v8js, veightjs]

(v8js is still needed because for attribute, root namespace is determined correctly)

Expected behavior
Group ID is not used to determine root namespace

Additional context
open-telemetry/semantic-conventions#1314

@lmolkova
Copy link
Contributor Author

lmolkova commented Aug 7, 2024

Same problem on events + both use group id to filter deprecated things:

https://github.com/open-telemetry/weaver/blob/4886aaf17e0f6b6d0725add2f3f793d25dd448ad/defaults/jq/semconv.jq#L70C20-L70C23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To consider for the next release
Development

No branches or pull requests

1 participant