Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Json Schema is too strict for current model. #228

Open
MadVikingGod opened this issue Jul 3, 2024 · 0 comments
Open

Json Schema is too strict for current model. #228

MadVikingGod opened this issue Jul 3, 2024 · 0 comments

Comments

@MadVikingGod
Copy link
Contributor

Describe the bug
The schema currently produced by weaver is too restrictive for the current semantic convention model. When trying to validate a number of errors are shown, see gist

To Reproduce
Steps to reproduce the behavior:

Follow the behavior in the gist

Expected behavior
When validating with weaver schema the current model should pass. Similar to the current build tools schema:

$ yajsv -s build-tools-semconv.schema.json *.yaml 
url.yaml: pass
messaging-common.yaml: pass
session.yaml: pass
db-common.yaml: pass
general.yaml: pass
faas-common.yaml: pass
http-common.yaml: pass
network.yaml: pass

Additional context
The errors seem to be repeats of:

(root): registry_url is required
groups.0.attributes.0: brief is required
groups.0.attributes.0: name is required
groups.0.attributes.0: type is required
groups.0.attributes.0: Additional property ref is not allowed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

No branches or pull requests

1 participant