Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix jvm buffer metric schema translations #683

Merged

Conversation

trask
Copy link
Member

@trask trask commented Feb 1, 2024

This was wrong back to schema translation file v1.22.0.

Is it ok to fix old schema translation files?

Or should I only fix it in vnext?

@trask trask requested review from a team February 1, 2024 21:35
@trask
Copy link
Member Author

trask commented Feb 1, 2024

well, I guess this answers my question 😄

./internal/tools/schema_check.sh
Ensure schema file /home/runner/work/semantic-conventions/semantic-conventions/schemas/1.24.0 exists... OK, exists.
Ensure published schema file https://opentelemetry.io/schemas/1.24.0 matches local copy... 9[5](https://github.com/trask/semantic-conventions/actions/runs/7747920963/job/21129451676#step:3:6),9[6](https://github.com/trask/semantic-conventions/actions/runs/7747920963/job/21129451676#step:3:7)c[9](https://github.com/trask/semantic-conventions/actions/runs/7747920963/job/21129451676#step:3:10)5,96
<               - jvm.buffer.usage
<               - jvm.buffer.limit
---
>               - jvm.buffer.memory.usage
>               - jvm.buffer.memory.limit
Incorrect!

Copy link
Contributor

@breedx-splk breedx-splk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @trask .

@arminru arminru added the Skip Changelog Label to skip the changelog check label Feb 6, 2024
@arminru arminru merged commit 2ff370d into open-telemetry:main Feb 6, 2024
10 of 11 checks passed
@trask trask deleted the fix-jvm-buffer-schema-translation branch October 14, 2024 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Skip Changelog Label to skip the changelog check
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

5 participants