-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Define additional Azure messaging attributes #572
Merged
joaopgrassi
merged 6 commits into
open-telemetry:main
from
lmolkova:azure-messaging-attributes
Feb 1, 2024
Merged
Define additional Azure messaging attributes #572
joaopgrassi
merged 6 commits into
open-telemetry:main
from
lmolkova:azure-messaging-attributes
Feb 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lmolkova
force-pushed
the
azure-messaging-attributes
branch
from
December 13, 2023 18:33
fd5dc7f
to
3d64d2a
Compare
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
pyohannes
reviewed
Jan 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This requires some rebasing, but otherwise looks good to me.
lmolkova
force-pushed
the
azure-messaging-attributes
branch
from
January 27, 2024 02:49
3d64d2a
to
f736ec1
Compare
pyohannes
approved these changes
Jan 29, 2024
joaopgrassi
approved these changes
Jan 29, 2024
trask
reviewed
Jan 29, 2024
trask
approved these changes
Feb 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
azure_<system>
to - see Guidance on product/project name inside attribute/metric name #608Merge requirement checklist
schema-next.yaml