Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change sampling relevant from MUST to SHOULD (and update build-tools version) #486

Merged
merged 2 commits into from
Nov 2, 2023

Conversation

trask
Copy link
Member

@trask trask commented Nov 2, 2023

Follow-up to open-telemetry/build-tools#230

Fixes #422

Changes

Change sampling relevant from MUST to SHOULD.

Merge requirement checklist

@trask trask marked this pull request as ready for review November 2, 2023 15:25
@trask trask requested review from a team November 2, 2023 15:25
Copy link
Member

@arminru arminru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also bump the semconv tool reference in open-telemetry/semantic-conventions/model/README.md (3x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Sampling relevant attributes: MUST vs SHOULD
4 participants