Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[editorial] Advisory parameter anchor name fix #420

Merged
merged 2 commits into from
Oct 18, 2023
Merged

[editorial] Advisory parameter anchor name fix #420

merged 2 commits into from
Oct 18, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented Oct 17, 2023

@chalin chalin requested review from a team October 17, 2023 12:42
trask
trask approved these changes Oct 17, 2023
View reviewed changes
Copy link
Member

@trask trask left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

interesting, I think anchors used to get checked, see tcort/markdown-link-extractor#25

@joaopgrassi joaopgrassi merged commit aebcb07 into open-telemetry:main Oct 18, 2023
9 checks passed
@chalin chalin deleted the chalin-im-advisory-param-anchor-fix-2023-10-17 branch October 18, 2023 17:41
@chalin chalin mentioned this pull request Aug 3, 2024
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@trask trask trask approved these changes

Assignees

@arminru arminru

Labels
None yet
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[editorial] Broken link hashes because #instrument-advice was renamed #instrument-advisory-parameters
4 participants
@chalin @trask @joaopgrassi @arminru