Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Moved container attributes to the registry #417

Merged
merged 14 commits into from
Oct 27, 2023
Merged

Moved container attributes to the registry #417

merged 14 commits into from
Oct 27, 2023

Conversation

ChrsMark
Copy link
Member

Changes

Refactoring: moves container.* attributes to the attributes registry

Merge requirement checklist

@ChrsMark ChrsMark requested review from a team October 17, 2023 08:49
@ChrsMark ChrsMark mentioned this pull request Oct 17, 2023
Open
68 tasks
trisch-me
trisch-me requested changes Oct 17, 2023
View reviewed changes
Copy link
Contributor

@trisch-me trisch-me left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please update the requirement level, otherwise lgtm

@ChrsMark
Moved container attributes to the registry
e61f37c 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark
Move OCI attributes to the registry
5f1a567 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark
remove blank lines
5dbeeb2 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark
Move requirement_level back
44844a6 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark
Add missing attribute
a39e84c 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark
Move oci to separate file
cc38e66 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark
merge semconv definitions
57ba587 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark
lint
d078ad9 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark
remove blank lines
23f3e49 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark
change registry to use attribute_group type
90af110 
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@AlexanderWert AlexanderWert merged commit 9b7193a into open-telemetry:main Oct 27, 2023
9 checks passed
@lmolkova lmolkova mentioned this pull request Sep 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyohannes pyohannes pyohannes approved these changes

@kaiyan-sheng kaiyan-sheng kaiyan-sheng approved these changes

@trisch-me trisch-me trisch-me approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@AlexanderWert AlexanderWert AlexanderWert approved these changes

Assignees

@arminru arminru

Labels
None yet
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ChrsMark @AlexanderWert @joaopgrassi @trisch-me @kaiyan-sheng @pyohannes @arminru