Add cardinality warning about two opt-in HTTP metric attributes to all HTTP metrics. #412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
fix-warning
branch
3 times, most recently
from
95cde14
to
f0bd89c
Compare
2 tasks
lmolkova
approved these changes
Oct 16, 2023
Merged
2 tasks
arminru
approved these changes
Oct 17, 2023
joaopgrassi
approved these changes
Oct 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Missed that only one of the HTTP metrics got updated in #401.
Changes
Add cardinality warning about two opt-in HTTP metric attributes to all HTTP metrics.
Merge requirement checklist
schema-next.yaml updated with changes to existing conventions.