Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING: Remove server.socket.address attribute from http and rpc metrics #350

Merged
merged 2 commits into from
Oct 2, 2023
Merged

BREAKING: Remove server.socket.address attribute from http and rpc metrics #350

merged 2 commits into from
Oct 2, 2023

Conversation

trask
Copy link
Member

@trask trask commented Sep 27, 2023

Fixes #341

Changes

Removes server.socket.address attribute from http and rpc metrics.

Merge requirement checklist

@trask trask requested review from a team September 27, 2023 03:40
@trask trask force-pushed the remove-socket-address-from-metric branch 4 times, most recently from b1586cf to bd7595b Compare September 27, 2023 04:07
@pyohannes
Copy link
Contributor

@lmolkova I guess we should also apply this change to #163 (for adding messaging metrics): https://github.com/open-telemetry/semantic-conventions/pull/163/files#diff-1c3afdf1b3b840fc9e4c17a2110573d1656b7e27d75b13f4ce97e2daff22517bR47

@pyohannes pyohannes mentioned this pull request Sep 27, 2023
Merged
arminru
arminru approved these changes Sep 27, 2023
View reviewed changes
CHANGELOG.md Show resolved Hide resolved
@trask trask force-pushed the remove-socket-address-from-metric branch from bd7595b to ec7feeb Compare September 29, 2023 19:09
jsuereth
jsuereth approved these changes Oct 2, 2023
View reviewed changes
Copy link
Contributor

@jsuereth jsuereth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would like to see us update schema files to handle this at some point, but this is certainly a breaking change (and a very needed one).

@trask trask changed the title Remove server.socket.address attribute from http and rpc metrics BREAKING: Remove server.socket.address attribute from http and rpc metrics Oct 2, 2023
@joaopgrassi joaopgrassi merged commit 5628684 into open-telemetry:main Oct 2, 2023
9 checks passed
@trask trask deleted the remove-socket-address-from-metric branch October 2, 2023 16:32
breedx-splk pushed a commit to breedx-splk/semantic-conventions that referenced this pull request Oct 3, 2023
@trask @breedx-splk
BREAKING: Remove server.socket.address attribute from http and rpc …
714041f 
…metrics (open-telemetry#350)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pyohannes pyohannes pyohannes approved these changes

@arminru arminru arminru approved these changes

@joaopgrassi joaopgrassi joaopgrassi approved these changes

@lmolkova lmolkova lmolkova approved these changes

@AlexanderWert AlexanderWert AlexanderWert approved these changes

@jsuereth jsuereth jsuereth approved these changes

Assignees

@arminru arminru

Labels
None yet
Projects
Semantic Conventions Triage
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Should server.socket.address be included on http.client.request.duration metric?
7 participants
@trask @pyohannes @jsuereth @AlexanderWert @lmolkova @joaopgrassi @arminru