Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[resource/host] Define host.mac semantic convention #340

Merged
merged 13 commits into from
Nov 2, 2023

Conversation

mx-psi
Copy link
Member

@mx-psi mx-psi commented Sep 22, 2023

Updates #131

Changes

Add host.mac semantic convention to list MAC addresses of a host.

Merge requirement checklist

@mx-psi mx-psi marked this pull request as ready for review September 22, 2023 12:30
@mx-psi mx-psi requested review from a team September 22, 2023 12:30
docs/resource/host.md Outdated Show resolved Hide resolved
@mx-psi
Copy link
Member Author

mx-psi commented Oct 11, 2023

@open-telemetry/semconv-system-approvers PTAL!

@mx-psi
Copy link
Member Author

mx-psi commented Oct 25, 2023

@open-telemetry/specs-semconv-maintainers This is ready for a review from maintainers.

The only remaining point of contention is the name, since host.mac could be argued to be singular but its type is an array, similar to the discussion at #203. We don't have a strong opinion on the system semconv WG over whether the plural rule should be followed as opposed to preserving backwards compatibility with ECS, so we believe it is up to maintainers now to decide on this :)

@joaopgrassi
Copy link
Member

This is essentially the same discussion as with the host.ip and ECS. I'm inclined to accept it under host.mac for the same reasons the other was accepted.

@jsuereth jsuereth merged commit c34ca40 into open-telemetry:main Nov 2, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

8 participants