Rename jvm.buffer.(usage|limit) to jvm.buffer.memory.(usage|limit) #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trask
force-pushed
the
qualify-jvm-buffer-usage-and-limit
branch
from
e5f31e2
to
19046c5
Compare
trask
force-pushed
the
qualify-jvm-buffer-usage-and-limit
branch
from
19046c5
to
233a798
Compare
joaopgrassi
approved these changes
Aug 16, 2023
mateuszrzeszutek
approved these changes
Aug 16, 2023
jack-berg
approved these changes
Aug 16, 2023
arminru
approved these changes
Aug 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes open-telemetry/opentelemetry-specification#3483
This helps clarify the difference with
jvm.buffer.countwhich is the number of buffers.Changes
Rename
jvm.buffer.usagetojvm.buffer.memory.usageand renamejvm.buffer.limittojvm.buffer.memory.limit.Merge requirement checklist