Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken docker link #1332

Merged
merged 4 commits into from
Aug 19, 2024
Merged

Conversation

ChrsMark
Copy link
Member

@ChrsMark ChrsMark commented Aug 14, 2024

Fixes #

Changes

The link https://docs.docker.com/engine/reference/run/#container-identification is outdated. This makes the markdown-link-check to fail.

Spotted at https://github.com/open-telemetry/semantic-conventions/actions/runs/10383411357/job/28748273043?pr=1251.

Merge requirement checklist

Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark ChrsMark requested review from a team August 14, 2024 07:46
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
@ChrsMark
Copy link
Member Author

Hmm, it seems that docker's doc pages are failing here there actually 🤔 .

@jsuereth
Copy link
Contributor

Sometimes websites prevent bots from hitting them. We may want to remove dockerhub as a validated location in the link checker...

@lmolkova
Copy link
Contributor

I think it'll self-heal - docker/docs#20606

@lmolkova
Copy link
Contributor

I think it'll self-heal - docker/docs#20606

self-healed!

@lmolkova lmolkova merged commit f8d14b6 into open-telemetry:main Aug 19, 2024
13 checks passed
ezimuel pushed a commit to ezimuel/semantic-conventions that referenced this pull request Aug 20, 2024
Signed-off-by: ChrsMark <chrismarkou92@gmail.com>
Co-authored-by: Liudmila Molkova <limolkova@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants