-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add 'log.record.original' attribute #1217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed through the linked spec issue and I see most folks agree with a semantic conventions for this, but I wonder what will be the outcome of having this convention here? Will then receivers have to build knowledge of this semantic field? What is the overall plan? I ask because your last comment there says there's no support for it so I wonder what the convention will solve.
Co-authored-by: Tigran Najaryan <4194920+tigrannajaryan@users.noreply.github.com>
Even if there is no functionality provided for this attribute, it will be helpful for users who are looking for a standard way to back up the original log value. The question of how to properly preserve it has come up many times and this would provide a standard answer. For example, one team may make a point to populate this attribute according the description, without any need to understand whether or how it will be used. Another team downstream can check for the attribute and use it is present. That said, if this is released I will propose adding support to several receivers in the collector. Tentatively, that functionality may include:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@djaglowski thanks for the explanation!
Fixes #1137
Changes
Add 'log.record.original' attribute.
Merge requirement checklist
[chore]