Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General error.type definition should clarify that fully qualified exception type name should be used #855

Open
1 of 2 tasks
lmolkova opened this issue Mar 28, 2024 · 1 comment
Assignees
Labels
area:error bug Something isn't working

Comments

@lmolkova
Copy link
Contributor

lmolkova commented Mar 28, 2024

Area(s)

area:error

What happened?

Description

Common definition of error.type doesn't mention that fully qualified name should be used (when exception type is recorded).

It's specifically important on Python where exception_type.__name__ is not qualified.

Expected Result

Here's how we recommend it in HTTP semconv

[1]: If the request fails with an error before response status code was sent or received, error.type SHOULD be set to exception type (its fully-qualified class name, if applicable) or a component-specific low cardinality error identifier.

TODO:

Semantic convention version

1.24.0

Additional context

No response

@joaopgrassi
Copy link
Member

I will send a PR to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:error bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants