Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce service graph metrics #826

Open
frzifus opened this issue Mar 19, 2024 · 4 comments
Open

introduce service graph metrics #826

frzifus opened this issue Mar 19, 2024 · 4 comments
Labels
area:new enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve

Comments

@frzifus
Copy link
Member

frzifus commented Mar 19, 2024

Area(s)

area:new

Is your change request related to a problem? Please describe.

Generating metrics to describe the relationship between services is generally very useful for inspecting systems. The servicegraphconnector provides a way to generate service graph metrics based on trace data. While details about the metrics are listed in the documentation those are tied to its implementation. Having a aligned spec would allow serve as a source of truth for other producers to be compatible (e.g. envoy) and consumers (e.g. grafana).

Describe the solution you'd like

Having a common schema for service graph metrics.

Describe alternatives you've considered

No response

Additional context

cc @Juraci @andreasgerstmayr

@frzifus frzifus added enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve triage:needs-triage labels Mar 19, 2024
@frzifus
Copy link
Member Author

frzifus commented Mar 22, 2024

@carsonip

@joaopgrassi
Copy link
Member

This sounds very cool and useful! But I do worry that when bringing the metrics to semconv, we will have to adjust the naming. Given there are products already offering service graph support for them, I wonder how breaking changes will be seen. Was this discussed in any way in the collector SIG @frzifus ?

@frzifus
Copy link
Member Author

frzifus commented Aug 29, 2024

Not yet official. The topic came up during a brainstorming debate at kubecon.

As of today, the metric list is not yet very large. Thats why I wouldn't be too worried about breaking changes in naming. More about the question of whether there is time to deal with the topic appropriately.

@joaopgrassi
Copy link
Member

Alright thanks for the additional info! I think this is a good idea and semconv is the right place for it. I will remove the triage label and keep it as is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:new enhancement New feature or request experts needed This issue or pull request is outside an area where general approvers feel they can approve
Projects
None yet
Development

No branches or pull requests

3 participants