Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Combine db.instance.id and db.name into a single attribute #749

Closed
trask opened this issue Feb 14, 2024 · 1 comment
Closed

Combine db.instance.id and db.name into a single attribute #749

trask opened this issue Feb 14, 2024 · 1 comment
Assignees

Comments

@trask
Copy link
Member

trask commented Feb 14, 2024

We've gotten feedback that db.instance.id and db.name are confusing for a couple of reasons:

To address this, one proposal we discussed in the database client semconv group is to combine these two into a single (more generically named) attribute, e.g. db.scope, which wouldn't conflict with existing database terminology.

DB-specific conventions could still define attributes which correspond to their preferred terminology, e.g. db.oracle.instance and db.oracle.schema.

We would need to define for each database what to populate into this new attribute, e.g. for Oracle it could be {db.oracle.instance}.{db.oracle.schema}.

Related to

@trask
Copy link
Member Author

trask commented Apr 24, 2024

Resolved by #911

@trask trask closed this as completed Apr 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants