Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Database errors in metrics #693

Closed
careless6666 opened this issue Feb 6, 2024 · 3 comments
Closed

Database errors in metrics #693

careless6666 opened this issue Feb 6, 2024 · 3 comments
Assignees

Comments

@careless6666
Copy link

Now the convention only has success metrics
https://github.com/open-telemetry/semantic-conventions/blob/main/docs/database/database-metrics.md

How about adding a label about the error or new metric?

The error can occur both when opening a connection and when executing a request (command)

@lmolkova
Copy link
Contributor

lmolkova commented Feb 9, 2024

Now that we have generic error.type attribute, we should be able to address it.

@jack-berg
Copy link
Member

Does error.type make sense for any of the existing metrics? It seems like no. I do think error.type makes sense for the client operation duration metric proposed in #512.

@careless6666
Copy link
Author

Yes, that's what I need

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

4 participants