Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify primary server name section of HTTP semconv server.address #414

Closed
trask opened this issue Oct 16, 2023 · 1 comment · Fixed by #423
Closed

Simplify primary server name section of HTTP semconv server.address #414

trask opened this issue Oct 16, 2023 · 1 comment · Fixed by #423
Assignees

Comments

@trask
Copy link
Member

trask commented Oct 16, 2023

from @lmolkova's #388 (comment):

change "The primary server name of the matched virtual host" to something like "Explicit user configuration (if provided) or a primary server name"

and @Oberon00's #388 (comment):

I agree that "virtual host" verbiage could/should probably be removed and replaced by something simpler.

@trask
Copy link
Member Author

trask commented Oct 16, 2023

Explicit user configuration (if provided) or a primary server name

are you thinking instrumentation configuration? do we need to mention that? or is this important enough to include something like "instrumentation SHOULD provide configuration"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

2 participants