Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make network.type opt-in for HTTP semconv spans and metrics? #403

Closed
trask opened this issue Oct 13, 2023 · 1 comment · Fixed by #410
Closed

Make network.type opt-in for HTTP semconv spans and metrics? #403

trask opened this issue Oct 13, 2023 · 1 comment · Fixed by #410
Assignees

Comments

@trask
Copy link
Member

trask commented Oct 13, 2023

I'm not sure that knowing ipv4 vs ipv6 is a generally useful piece of data in the scope of HTTP semconv (worth capturing by default on all HTTP spans).

Should we remove it, or explicitly make it opt-in?

@lmolkova
Copy link
Contributor

lmolkova commented Oct 13, 2023

Assuming the backend does not want to parse the IP address it does not need the type. It's still obvious (on traces) if the network.peer.address is IPv4 or IPv6. Even if instrumentations don't populate it, backends MAY figure out the type.

But metrics are more interesting: I assume it might be interesting how much traffic is coming over ipv4 vs ipv6.

I'd be in favor of keeping it on traces, adding to metrics, and making it opt-in on both.

@trask trask changed the title Remove network.type from HTTP semconv, or explicitly make it opt-in? Make network.type opt-in for HTTP semconv spans and metrics? Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
3 participants