Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request to create semconv-mobile-approvers #343

Closed
AlexanderWert opened this issue Sep 25, 2023 · 11 comments
Closed

Request to create semconv-mobile-approvers #343

AlexanderWert opened this issue Sep 25, 2023 · 11 comments
Assignees

Comments

@AlexanderWert
Copy link
Member

AlexanderWert commented Sep 25, 2023

I'd like to request creating a new approvers group semconv-mobile-approvers that would be responsible for reviewing and maintaining semantic conventions related to the mobile domain (e.g. iOS, Android).

Folks proposed for that group / interested:

Related PRs and issues:

@breedx-splk
Copy link
Contributor

Count me in. Thanks!

@surbhiia
Copy link
Contributor

If you need more approvers from Android, I would like to participate as well. :)

@marandaneto
Copy link
Member

Same, I'd like to contribute as an approver if possible.

@bryce-b
Copy link
Member

bryce-b commented Sep 26, 2023

I'm in

@arminru
Copy link
Member

arminru commented Oct 3, 2023

I created @open-telemetry/semconv-mobile-approvers and added everyone stated in the description who is already a member of the OTel organization.

You can go ahead and update the code owners file to cover the subpaths where the mobile semantic conventions will reside.

@bidetofevil @surbhiia @marandaneto please take a look at our community membership guidelines and follow the process documented there for becoming a member so I can add you as well.

@marandaneto
Copy link
Member

@arminru do you mean this?

@arminru
Copy link
Member

arminru commented Oct 4, 2023

@marandaneto Exactly! Thanks for the link, I forgot to paste it above 🙂

@marandaneto
Copy link
Member

@marandaneto Exactly! Thanks for the link, I forgot to paste it above 🙂

Done, the issue is open, but I don't have sponsors nor have previously contributed directly.
How do I proceed? do I need to reach out to folks and try to get sponsors on my own? Also, do I need to contribute before being part of the new group?

@arminru
Copy link
Member

arminru commented Oct 4, 2023

Hey @marandaneto!

Only to become a formal approver you'd first need to be a community member, for which the requirements are defined in the community repo.

You're more than happy to already contribute to all efforts, working groups and discussions also as someone new to OpenTelemetry, and you're also able to review PRs. The only difference is that only approvals from formal approvers count towards our merge requirements.

The requirement for having sponsors for membership requests is to ensure those sponsors are able to confirm someone is a credible contributor with good reasoning. Once you've contributed to OTel for a bit, it should be easy for others in the community to make such judgments and sponsor your request.

@surbhiia
Copy link
Contributor

surbhiia commented Oct 4, 2023

Thanks @arminru for sharing the details. I've created an issue here to become a member. I'll let you know once it's closed.

@arminru
Copy link
Member

arminru commented Oct 6, 2023

Team created and added to CODEOWNERS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants