You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
To ensure the Schema files correctly capture changes we make to semantic conventions I suggest that we add an automatic check that verifies that any PR that changes a semantic convention in a way that matters from Schema file perspective enforces that the Schema file change is also present (and ideally verifies that the changes match).
The only supported Schema file change is currently the renaming of attributes so the check needs to see any of attribute name is changed semantic convention yaml file and see if there is a corresponding change recorded in the Schema file.
The text was updated successfully, but these errors were encountered:
Help is needed on this one, especially if you are familiar with build-tools that generate the semantic conventions currently.
tigrannajaryan
changed the title
Add a PR check to enforce Schema file presence if a semantic convention is changed
Add a PR check to enforce Schema file presence/content if a semantic convention is changed
Sep 21, 2021
+1. I thought we already had that, since it was called out in the original schemas OTEP.
No yet. We have a check that verifies that every release has a corresponding Schema file. But we don't yet check individual PRs that modify semantic conventions.
To ensure the Schema files correctly capture changes we make to semantic conventions I suggest that we add an automatic check that verifies that any PR that changes a semantic convention in a way that matters from Schema file perspective enforces that the Schema file change is also present (and ideally verifies that the changes match).
The only supported Schema file change is currently the renaming of attributes so the check needs to see any of attribute name is changed semantic convention yaml file and see if there is a corresponding change recorded in the Schema file.
The text was updated successfully, but these errors were encountered: