Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to model Semantic Conventions for Database Transactions #1134

Open
tkmsaaaam opened this issue Jun 9, 2024 · 0 comments
Open

How to model Semantic Conventions for Database Transactions #1134

tkmsaaaam opened this issue Jun 9, 2024 · 0 comments
Labels
area:db enhancement New feature or request

Comments

@tkmsaaaam
Copy link

Area(s)

area:db

Is your change request related to a problem? Please describe.

In this repository, model calls in the database semantic conventions are already defined. However, database transactions have not yet been defined. Therefore, I think it needs to be defined. This is the issue that prompted this issue. open-telemetry/opentelemetry-java-instrumentation#10381

Describe the solution you'd like

I think most of the attributes of the transaction are the same at the time of the call.
https://github.com/open-telemetry/semantic-conventions/blob/ca6e1c5df5efd7f746266cff0dbaab5672a251c3/docs/database/database-spans. md
https://github.com/open-telemetry/semantic-conventions/blob/ca6e1c5df5efd7f746266cff0dbaab5672a251c3/docs/database/sql.md
https://github.com/open-telemetry/semantic-conventions/blob/ca6e1c5df5efd7f746266cff0dbaab5672a251c3/docs/database/mssql.md

However, you need to define db.operation.name.
I think it should be COMMIT TRANSACTION and ROLLBACK TRANSACTION.

Describe alternatives you've considered

No response

Additional context

No response

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:db enhancement New feature or request
Projects
Status: Post Stability
Development

No branches or pull requests

3 participants