Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename reference/spec to specification/otel and add OTLP submodule #2677

Merged
merged 3 commits into from
May 9, 2023
Merged

Rename reference/spec to specification/otel and add OTLP submodule #2677

merged 3 commits into from
May 9, 2023

Conversation

chalin
Copy link
Contributor

@chalin chalin commented May 8, 2023 •
edited
Loading

  • Prep for Adjust to move of OTLP specs into opentelemetry-proto #2642
  • Adds OTLP repo as a submodule under content-modules/opentelemetry-proto
    Note: the content is not yet displayed, this PR only adds the submodule
  • Moves /docs/reference/specification to /docs/specification/otel
  • Accordingly adjusts some links to refer to the new OTel spec home, but not all (I've temporarily added an ignore rule to the link checker config)

Preview:

Redirect rule tests:

@chalin chalin requested review from a team May 8, 2023 19:17
@chalin chalin mentioned this pull request May 8, 2023
Closed
14 tasks
@chalin
Copy link
Contributor Author

chalin commented May 8, 2023

/cc @open-telemetry/specs-approvers

ferd
ferd approved these changes May 8, 2023
View reviewed changes
Copy link
Member

@ferd ferd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems okay from the Erlang/Elixir side.

svrnm
svrnm approved these changes May 9, 2023
View reviewed changes
Copy link
Member

@svrnm svrnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm.

@chalin please merge this based on your needs

@chalin chalin force-pushed the chalin-im-add-otlp-submodule-2023-05-08 branch from 3a91de6 to 0b699b8 Compare May 9, 2023 14:34
@chalin chalin merged commit dc4031a into open-telemetry:main May 9, 2023
@chalin chalin deleted the chalin-im-add-otlp-submodule-2023-05-08 branch May 9, 2023 14:39
This was referenced May 10, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ferd ferd ferd approved these changes

@svrnm svrnm svrnm approved these changes

@tigrannajaryan tigrannajaryan tigrannajaryan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@chalin @ferd @svrnm @tigrannajaryan