Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Incremental improvements for migration docs #2657

Merged
merged 9 commits into from
May 8, 2023
Merged

Incremental improvements for migration docs #2657

merged 9 commits into from
May 8, 2023

Conversation

svrnm
Copy link
Member

@svrnm svrnm commented May 5, 2023

Some incremental improvements for migration docs:

  • Some introduction for where Otel comes from and why we provide oc & ot migration (copied some of your words @aabmass, hope that's OK :))
  • Also some words about jaeger (copied from the jaeger docs (cc @pavolloffay) & @jpkrohling blog post)
  • Linked to the spec for OpenCensus for now, not sure if this works in the long run and if we might need a separate migration guide like we have one for ot

@svrnm
Incremental improvements for migration docs
397c2c5 
Signed-off-by: svrnm <neumanns@cisco.com>
@svrnm svrnm requested a review from a team May 5, 2023 13:29
cartermp
cartermp approved these changes May 5, 2023
View reviewed changes
Copy link
Contributor

@cartermp cartermp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, love it!

@cartermp
Copy link
Contributor

cartermp commented May 5, 2023

Looks like there's another formatting push to make here 🙃

chalin
chalin reviewed May 7, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

See inline comments for link-check fix and more.

@chalin
Copy link
Contributor

chalin commented May 7, 2023

Looks like there's another formatting push to make here 🙃

@cartermp - the formatting seems file (the action is passing) -- unless I missed something. Were you referring to the link-check failure?

svrnm and others added 7 commits May 8, 2023 09:46
@svrnm @chalin
Update content/en/docs/migration/_index.md
8eb7289 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@svrnm @chalin
Update content/en/docs/migration/opencensus.md
2918f16 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@svrnm @chalin
Update .htmltest.yml
13f27ac 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@svrnm @chalin
Update content/en/docs/migration/_index.md
55b9291 
Co-authored-by: Patrice Chalin <chalin@users.noreply.github.com>
@svrnm
Update _index.md
7fa45fe
@svrnm
Merge branch 'main' into some-more-migration-instructions
2a03956
@svrnm
Merge branch 'main' into some-more-migration-instructions
b17bcc9
chalin
chalin approved these changes May 8, 2023
View reviewed changes
Copy link
Contributor

@chalin chalin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@chalin chalin merged commit e9d1485 into open-telemetry:main May 8, 2023
@svrnm svrnm deleted the some-more-migration-instructions branch May 11, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chalin chalin chalin approved these changes

@cartermp cartermp cartermp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@svrnm @cartermp @chalin