Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Create an action to run npm run sync #3950

Closed
Tracked by #3916
chalin opened this issue Feb 6, 2024 · 1 comment · Fixed by #3955
Closed
Tracked by #3916

[CI] Create an action to run npm run sync #3950

chalin opened this issue Feb 6, 2024 · 1 comment · Fixed by #3955
Labels
CI/infra CI & infrastructure e0-minutes Effort: < 60 min e1-hours Effort: < 8 hrs p2-medium

Comments

@chalin
Copy link
Contributor

chalin commented Feb 6, 2024

Originally posted by @svrnm in #3948 (comment):

First: +1 for npm run sync fixing 80% of that, I used it the other day and it does a perfect job, maybe we can turn this into a /fix:sync as well?

Great idea to have a /fix:* trigger for npm run sync. Candidate command names:

  • /fix:submodules
  • /fix:modules
  • /sync:submodules -- we don't really have to stick to the fix prefix

Other suggestions are welcome.

@chalin chalin added CI/infra CI & infrastructure e0-minutes Effort: < 60 min e1-hours Effort: < 8 hrs p2-medium labels Feb 6, 2024
@svrnm
Copy link
Member

svrnm commented Feb 6, 2024

/fix:submodules sounds good to me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/infra CI & infrastructure e0-minutes Effort: < 60 min e1-hours Effort: < 8 hrs p2-medium
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants