-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adjust to move of OTLP specs into opentelemetry-proto #2642
Comments
@open-telemetry/docs-approvers can you please help with this? |
@chalin can you give this a look? ty |
So what is it that you would like to see on the website @tigrannajaryan and @open-telemetry/specs-approvers? Two options come to mind and are presented below. Let me know which you prefer, or whether you had something else in mind. 1. Publish the OTLP spec separately under "Reference"Something like this: 2. Publish the
|
I prefer this. |
I would also prefer (1), looks more user-friendly Option (1) also has the advantage that the "Reference >" top level item is not only having one child, which is kind of confusing. We should also add a section on the Reference page that explains what people will find here and what the differences are (not everybody is aware what OTel/OTLP stands for and what the differences are) |
voted 1 |
- Adjusts linkTitle in support of open-telemetry/opentelemetry.io#2642 - Was originally: Drops linkTitle because it is auto-generated since open-telemetry/opentelemetry.io#2666
…field (#3481) - Adjusts linkTitle - Contributes to open-telemetry/opentelemetry.io#2642 - Was originally: - Drops linkTitle because it is auto-generated since open-telemetry/opentelemetry.io#2666 - Contributes to open-telemetry/opentelemetry.io#2387 Co-authored-by: Reiley Yang <reyang@microsoft.com>
1 for me as well |
@tigrannajaryan and @open-telemetry/specs-approvers I have a question for you: The OTLP spec pages link to (a) Host the proto files on the website (as static assets) and point to the website-local files While (b) is the simplest solution, there's the potential problem that the site's OTLP docs and the repo's Option (c) also guarantees that the docs and proto files remain in sync, but it implies that we would never be able (easily) host OTLP docs other than at a tagged release. Thoughts? |
Both options (a) and (c) are fine with me. I think we only want to host tagged releases on the website. Anybody who is interested in the head can work directly with the opentelemetry-proto repo. |
Thanks for the feedback @tigrannajaryan. Can we make some progress on getting open-telemetry/opentelemetry-proto#469 approved and merged? I'm waiting on that before I before I bring it in (though it's approved and the merge is delayed, I can implement the new directory structure in this repo, temporarily). |
…oto (#3454) Resolves #3415 Depends on open-telemetry/opentelemetry-proto#458 Depends on open-telemetry/opentelemetry.io#2642
…3552) - Adds Hugo `linkTitle` to Protocol pages, to match OTLP pages - Contributes to open-telemetry/opentelemetry.io#2642 - Contributes to open-telemetry/opentelemetry.io#2793 /cc @svrnm @cartermp Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
…field (open-telemetry#3481) - Adjusts linkTitle - Contributes to open-telemetry/opentelemetry.io#2642 - Was originally: - Drops linkTitle because it is auto-generated since open-telemetry/opentelemetry.io#2666 - Contributes to open-telemetry/opentelemetry.io#2387 Co-authored-by: Reiley Yang <reyang@microsoft.com>
…pen-telemetry#3552) - Adds Hugo `linkTitle` to Protocol pages, to match OTLP pages - Contributes to open-telemetry/opentelemetry.io#2642 - Contributes to open-telemetry/opentelemetry.io#2793 /cc @svrnm @cartermp Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
We are moving OTLP spec from https://opentelemetry.io/docs/reference/specification/protocol/otlp/ to https://github.com/open-telemetry/opentelemetry-proto/tree/main/specification/ (pending open-telemetry/opentelemetry-proto#458).
We will need to update the documentation website appropriately (I am not sure how exactly it works today, so not sure what needs to change).
Note that only the following files are moving (not the entire directory):
Prep
Tasks
Run prettifier over OTLP spec pagesThe text was updated successfully, but these errors were encountered: