Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust to move of OTLP specs into opentelemetry-proto #2642

Closed
14 tasks done
Tracked by #2793 ...
tigrannajaryan opened this issue Apr 28, 2023 · 10 comments · Fixed by #2857
Closed
14 tasks done
Tracked by #2793 ...

Adjust to move of OTLP specs into opentelemetry-proto #2642

tigrannajaryan opened this issue Apr 28, 2023 · 10 comments · Fixed by #2857
Assignees
Labels

Comments

@tigrannajaryan
Copy link
Member

tigrannajaryan commented Apr 28, 2023

@tigrannajaryan
Copy link
Member Author

@open-telemetry/docs-approvers can you please help with this?

@svrnm svrnm added the CI/infra CI & infrastructure label May 2, 2023
@svrnm
Copy link
Member

svrnm commented May 2, 2023

@chalin can you give this a look? ty

@chalin chalin self-assigned this May 3, 2023
@chalin
Copy link
Contributor

chalin commented May 8, 2023

So what is it that you would like to see on the website @tigrannajaryan and @open-telemetry/specs-approvers?

Two options come to mind and are presented below. Let me know which you prefer, or whether you had something else in mind.

1. Publish the OTLP spec separately under "Reference"

Something like this:

Screen Shot 2023-05-08 at 08 40 18

2. Publish the opentelemetry-proto repo OTLP spec through it's current location in the OTel spec ...

... that is, https://opentelemetry.io/docs/reference/specification/protocol/otlp/, as an override to any pages that the OTel spec might provide.

While this option is minimally disruptive, it might lead to confusion if/once #2666 lands and the spec version is visible as part of the page title and breadcrumbs. That is, we might end up with something like this:

Screen Shot 2023-05-08 at 08 48 07

@tigrannajaryan
Copy link
Member Author

  1. Publish the OTLP spec separately under "Reference"

I prefer this.

@svrnm
Copy link
Member

svrnm commented May 8, 2023

I would also prefer (1), looks more user-friendly

Option (1) also has the advantage that the "Reference >" top level item is not only having one child, which is kind of confusing.

We should also add a section on the Reference page that explains what people will find here and what the differences are (not everybody is aware what OTel/OTLP stands for and what the differences are)

@chalin chalin changed the title Change OTLP docs to point to opentelemetry-proto Adjust to move of OTLP specs into opentelemetry-proto May 8, 2023
@austinlparker
Copy link
Member

voted 1

chalin added a commit to chalin/opentelemetry-specification that referenced this issue May 8, 2023
- Adjusts linkTitle in support of open-telemetry/opentelemetry.io#2642
- Was originally: Drops linkTitle because it is auto-generated since open-telemetry/opentelemetry.io#2666
reyang added a commit to open-telemetry/opentelemetry-specification that referenced this issue May 8, 2023
…field (#3481)

- Adjusts linkTitle
- Contributes to
open-telemetry/opentelemetry.io#2642
- Was originally:
- Drops linkTitle because it is auto-generated since
open-telemetry/opentelemetry.io#2666
- Contributes to
open-telemetry/opentelemetry.io#2387

Co-authored-by: Reiley Yang <reyang@microsoft.com>
@cartermp
Copy link
Contributor

cartermp commented May 9, 2023

1 for me as well

@chalin
Copy link
Contributor

chalin commented May 10, 2023

@tigrannajaryan and @open-telemetry/specs-approvers I have a question for you:

The OTLP spec pages link to .proto files. Where to you want these links to point to? I see 3 options:

(a) Host the proto files on the website (as static assets) and point to the website-local files
(b) Link to proto files in the OTLP repo @Head
(c) Link to proto files in the OTLP repo at a specific tagged release

While (b) is the simplest solution, there's the potential problem that the site's OTLP docs and the repo's .proto files might not correspond to the same version. By hosting the .proto files on the website (a), we guarantee that they sync.

Option (c) also guarantees that the docs and proto files remain in sync, but it implies that we would never be able (easily) host OTLP docs other than at a tagged release.

Thoughts?

@tigrannajaryan
Copy link
Member Author

Both options (a) and (c) are fine with me. I think we only want to host tagged releases on the website. Anybody who is interested in the head can work directly with the opentelemetry-proto repo.

@chalin
Copy link
Contributor

chalin commented May 10, 2023

Thanks for the feedback @tigrannajaryan.

Can we make some progress on getting open-telemetry/opentelemetry-proto#469 approved and merged? I'm waiting on that before I before I bring it in (though it's approved and the merge is delayed, I can implement the new directory structure in this repo, temporarily).

carlosalberto added a commit to open-telemetry/opentelemetry-specification that referenced this issue Jun 13, 2023
…3552)

- Adds Hugo `linkTitle` to Protocol pages, to match OTLP pages
- Contributes to
open-telemetry/opentelemetry.io#2642
- Contributes to
open-telemetry/opentelemetry.io#2793

/cc @svrnm @cartermp

Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
carlosalberto pushed a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 31, 2024
…field (open-telemetry#3481)

- Adjusts linkTitle
- Contributes to
open-telemetry/opentelemetry.io#2642
- Was originally:
- Drops linkTitle because it is auto-generated since
open-telemetry/opentelemetry.io#2666
- Contributes to
open-telemetry/opentelemetry.io#2387

Co-authored-by: Reiley Yang <reyang@microsoft.com>
carlosalberto added a commit to carlosalberto/opentelemetry-specification that referenced this issue Oct 31, 2024
…pen-telemetry#3552)

- Adds Hugo `linkTitle` to Protocol pages, to match OTLP pages
- Contributes to
open-telemetry/opentelemetry.io#2642
- Contributes to
open-telemetry/opentelemetry.io#2793

/cc @svrnm @cartermp

Co-authored-by: Carlos Alberto Cortez <calberto.cortez@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants