Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config_option shortcode is escaping HTML #2489

Open
chalin opened this issue Mar 13, 2023 · 6 comments
Open

config_option shortcode is escaping HTML #2489

chalin opened this issue Mar 13, 2023 · 6 comments
Labels
bug Something isn't working e0-minutes Effort: < 60 min p2-medium

Comments

@chalin
Copy link
Contributor

chalin commented Mar 13, 2023

Visit https://opentelemetry.io/docs/instrumentation/java/automatic/agent-config/#peer-service-name and you'll see:

Screen Shot 2023-03-12 at 20 17 37

It seems that Hugo's trim function is escaping HTML.

@chalin chalin added bug Something isn't working e0-minutes Effort: < 60 min p2-medium labels Mar 13, 2023
@svrnm svrnm added help wanted Extra attention is needed good first issue Good for newcomers labels Mar 13, 2023
@shyamtawli
Copy link

Hey can I work on it.

@chalin
Copy link
Contributor Author

chalin commented Mar 14, 2023

@svrnm - FYI, I'm going to remove the "good first issue" because I think this one is hitting a Hugo bug, and so it will likely require good knowledge of Hugo to investigate and resolve.

@chalin chalin removed help wanted Extra attention is needed good first issue Good for newcomers labels Mar 14, 2023
@svrnm
Copy link
Member

svrnm commented Mar 15, 2023

Thanks @chalin, my assumption was this is a quick fix by editing the file.

@shyamtawli apologies see chalin's comment above, this is not a good starter issue

@chalin
Copy link
Contributor Author

chalin commented Mar 15, 2023

No worries! It does look like a quick-fix candidate.

@shyamtawli
Copy link

No Issue @svrnm
I will see other beginner issues.

@chalin
Copy link
Contributor Author

chalin commented Mar 15, 2023

Thanks! For the record, it seems likely that Go templates are escaping based on context, similar to what happened in #2509, which was resolved via:

It's not clear to me why this is happening for a shortcode rendered as markdown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working e0-minutes Effort: < 60 min p2-medium
Projects
None yet
Development

No branches or pull requests

3 participants