Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mark the AddLink() operation as stable. #3887

Merged
merged 4 commits into from
Mar 8, 2024

Conversation

carlosalberto
Copy link
Contributor

@carlosalberto carlosalberto commented Feb 20, 2024

@cijothomas
Copy link
Member

Enough SIGs have implemented prototypes without any concern.

Is there anyway to find which SIGs have implemented this, given spec compliance matrix only shows C++?
See: #3865 (comment)

@carlosalberto
Copy link
Contributor Author

carlosalberto commented Feb 26, 2024

@cijothomas This comment mentions of the ones we know of (only C++ and Java have merged the PRs though). Will check the other ones (plus update the matrix).

Copy link

github-actions bot commented Mar 5, 2024

This PR was marked stale due to lack of activity. It will be closed in 7 days.

@github-actions github-actions bot added the Stale label Mar 5, 2024
@carlosalberto carlosalberto merged commit 928396b into open-telemetry:main Mar 8, 2024
7 checks passed
@carlosalberto carlosalberto deleted the stabilize-add-link branch March 8, 2024 16:26
@carlosalberto carlosalberto mentioned this pull request Mar 8, 2024
carlosalberto added a commit to carlosalberto/opentelemetry-specification that referenced this pull request Oct 31, 2024
Fixes open-telemetry#3865 

Enough SIGs have implemented prototypes without any concern. Also, no
actual need to detect whether links were added before or after Span
creation has received further attention, which previously was a blocker.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stabilize AddLink operation in Trace API
7 participants