Update semconv for hardware metrics to use direction attributes
#2942
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arminru
added
area:semantic-conventions
jmacd
approved these changes
Nov 17, 2022
jack-berg
approved these changes
Nov 21, 2022
|
@jack-berg CHANGELOG entry added! |
carlosalberto
approved these changes
Nov 22, 2022
|
This seems like a straightforward change to comply with the other metrics we already have cc @jsuereth |
arminru
approved these changes
Nov 23, 2022
|
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
|
Since everybody approved this, I guess it's time to hit that green Merge button 😉 |
|
@bertysentry Agreed. Sorry, can you merge again? :( |
|
@carlosalberto Merge done, all checks have passed, we're good to go! Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2805
Changes
Updated semantic conventions for hardware metrics (
specification\metrics\semantic_conventions\hardware-metrics.md) to use thedirectionattributes (and follow updated general semantic conventions).hw.gpu.io.receive,hw.gpu.io.transmit==>hw.gpu.iohw.network.io.receive,hw.network.io.transmit==>hw.network.iohw.network.packets.receive,hw.network.packets.transmit==>hw.network.packets