Align runtime metric and resource namespaces #2112
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsuereth
reviewed
Nov 9, 2021
There was a problem hiding this comment.
I appreciate the goal of trying to align the semantic conventions!
Would be good to have a x-link to the process runtime specification
A 'process.runtime' namespace is currently defined in the resource semantic conventions. The metric semantic conventions suggest that runtime metrics use a 'runtime' namespace. Since the runtime metrics are directly related to the runtime resources, they ought to share a common namespace.
djaglowski
force-pushed
the
runtime-resource
branch
from
9e85103
to
a041c82
Compare
|
@jsuereth I've added the link. Any other feedback @jsuereth, @tigrannajaryan? |
jsuereth
approved these changes
Nov 10, 2021
SergeyKanzhelev
approved these changes
Nov 10, 2021
|
@aabmass you are the author of the OTEP that introduced the Also, @james-bebbington @andrewhsu @justinfoote @jmacd @MrAlias @lzchen you approved the PR that introduced |
carlosalberto
approved these changes
Nov 17, 2021
tigrannajaryan
approved these changes
Nov 18, 2021
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A 'process.runtime' namespace is currently defined in the resource
semantic conventions. The metric semantic conventions suggest that
runtime metrics use a 'runtime' namespace. Since the runtime metrics
are directly related to the runtime resources, they ought to share a
common namespace.
Related to issue #2061, discussed in this comment.