-
Notifications
You must be signed in to change notification settings - Fork 888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Proposal: Define semantic conventions in JSON/YAML #547
Comments
Very interested in something like this |
Sounds about the right time to implement this one. On the specific points, for 3) I'd also vow for generated code. No strong opinion/feedback on the other two. |
Please +/- 1 the initial comment to count how many lgtms we have |
I like the idea! I am currently working exactly on this based on a yaml representation. Our plan was to propose this once the code generation tool was implemented for multiple languages. We could propose a PR with our current yaml representation and start discussing if the model makes sense to everyone 😄 |
@thisthat would be good to share why you decided on yaml in your experiment? May help us with the decision yaml vs json. |
I'd say JSON is not usable for human-written code, as it does not support comments. That's a killer-argument, as far as I'm concerned. |
At the current status, it is more than just an experiment since we are close to having the code generation. To answer your question @bogdandrutu: both have the same expressiveness power, are well known by the community, and have great tooling support, but yaml is more compact as a representation and has the possibility to have comments that can aid the readability/maintainability of the semantic convention. |
Guys this is a great opportunity to write our own config language and custom parser! j/k @thisthat I'm curious about what metadata you would want included with each entry, if the purpose is for code generation. An old (partial) implementation from the OpenTracing days: https://github.com/opentracing/specification/blob/master/semantic_conventions.yaml |
@tedsuo for code generation I mean:
|
This is a proposal to define all semantic conventions in a format that can be automatically parse by every language and generate constants without having to manually sync their constant definitions with the markdown text in this repository:
git submodules
to reference to that repositorygit submodule
is updated.git submodule
is updated.This will allow us to keep consistency between languages and consistent description for every semantic convention defined.
Open questions:
The text was updated successfully, but these errors were encountered: