[Prometheus Compatibility] Reconsider 1 to ratio unit conversion #4058
Labels
sig-issue
A specific SIG should look into this before discussing at the spec
spec:metrics
Related to the specification/metrics directory
spec:miscellaneous
For issues that don't match any other spec label
triage:accepted:ready-with-sponsor
Ready to be implemented and has a specification sponsor assigned
Context
Found as part of open-telemetry/opentelemetry-python#3924.
The semantic conventions for instrument unit recommend using annotations, rather than the unity:
The linked UCUM section says that annotations (e.g.
{RBC}
) and1
are equivalent:The current Prometheus Compatibility specification converts
1
toratio
:Problem
While
1
can be a ratio, it can also be a count of something, since it is equivalent to{RBC}
. Our spec discourages the use of1
as a count of something, but that still doesn't make it correct to automatically convert1
toratio
for Prometheus conversion.Proposal
Remove the special case for changing
1
toratio
in prometheus conversion.@bertysentry @open-telemetry/wg-prometheus @aabmass
The text was updated successfully, but these errors were encountered: